Skip to content

Validate strings are under 16mb instead of 128mb #67608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Validate strings are under 16mb instead of 128mb #67608

wants to merge 3 commits into from

Conversation

tryangul
Copy link
Contributor

@tryangul tryangul commented Oct 10, 2025 •
edited
Loading

What

Fix string validation

How

Properly use 16mb as the size instead of 128mb

Why

We were validating against the max configurable VARCHAR size, not the max size of VARCHAR type we use

@tryangul tryangul requested a review from a team as a code owner October 10, 2025 17:40
@github-actions GitHub Actions
Copy link
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
    • /bump-bulk-cdk-version type=patch changelog='foo' - Bump the Bulk CDK's version. type can be major/minor/patch.
  • Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

📝 Edit this welcome message.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025 •
edited
Loading

Deploy preview for airbyte-docs ready!

✅ Preview
https://airbyte-docs-c76drop1l-airbyte-growth.vercel.app

Built with commit ec1f341.
This pull request is being automatically deployed with vercel-action

@tryangul tryangul changed the title 16mb instead of 128 Validate strings are under 16mb instead of 128mb Oct 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

destination-snowflake Connector Test Results

 24 files   24 suites   13m 31s ⏱️
282 tests 250 ✅ 32 💤 0 ❌
286 runs  254 ✅ 32 💤 0 ❌

Results for commit ec1f341.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benmoriceau benmoriceau benmoriceau approved these changes

Assignees

No one assigned

Labels

connectors/destination/snowflake

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tryangul @benmoriceau @octavia-squidington-iii